-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add created branch (from dvc exp branch
) to the experiments table
#4857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sold on the utility of this. A few months ago we started moving away from auto-magical behaviour as it unnecessarily complicates the code and leads to unexpected behaviour for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I'm not expecting what I will say next to be added to this PR. It could be a follow-up for later on if we agree on it.
I feel like there is a good amount of time passing between when we create the branch, when we show the toast and when we add the branch.
It is a lot more advanced, but having some sort of loading at the bottom of the table from the time the user creates the branch to when we add the branch would feel less confusing for the user. Some message that says "branch-name
is being added to the table."
dvc exp branch
) to the experiments table
@sroy3 , with the latest change (only needing to run an update once), the table runs a lot faster. Plus, my computer tends to run on the slower side. If you have a chance, could you test this feature out with the newest changes? If it feels slow, I can work on adding a Toast message that says something like |
It does work almost instantly. Great work! |
Code Climate has analyzed commit 59e7445 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0%. View more on Code Climate. |
Demo
Screen.Recording.2023-10-18.at.5.21.09.PM.mov
Fixes https://iterativeai.slack.com/archives/C01APS0FHDM/p1697466359466489?thread_ts=1697456789.149749&cid=C01APS0FHDM